Re: [PATCH v3 0/4] A design for future-proofing fsync() configuration
From: Neeraj Singh <hidden>
Date: 2022-01-10 19:00:30
On Sat, Jan 8, 2022 at 4:55 PM [off-list ref] wrote:
Please remember that fsync() is operating system and version specific. You cannot make any assumptions about what is supported and what is not. I have recently had issues with git built on a recent operating system not running on a version from 2020. The proposed patches do not work, as I recall, in a portable manner, so caution is required making this change. You can expect this not to work on some platforms and some versions. Please account for that. Requiring users who are not aware of OS details to configure git to function at all is a bad move, in my view - which has not changed since last time.
There was already an implied configuration of fsync in the Git codebase. None of the defaults are changing--assuming that a user does not explicitly configure the core.fsync setting, Git should work the same as it always has. I don't believe the current patch series introduces any new incompatibilities. Thanks, Neeraj