Thread (1 message) 1 message, 1 author, 2022-01-05

Re: [PATCH v4 1/2] name-rev: deprecate --stdin in favor of --annotate-stdin

From: Junio C Hamano <hidden>
Date: 2022-01-05 19:52:08

Phillip Wood [off-list ref] writes:
quoted
@@ -539,6 +539,7 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix)
  		OPT_GROUP(""),
  		OPT_BOOL(0, "all", &all, N_("list all commits reachable from all refs")),
  		OPT_BOOL(0, "stdin", &transform_stdin, N_("read from stdin")),
If the intention is to deprecate this option then it might be worth
marking it as PARSE_OPT_HIDDEN so that it is not shown by 'git
name-rev -h'. (You need to change OPT_BOOL to OPT_BOOL_F to pass the
flag)
Whether we want to do HIDDEN now or not, it is probably a good idea
to update the help text to 

	N_("deprecated synonym to --annotate-stdin")

or something like that.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help