Re: [PATCH v4 1/2] name-rev: deprecate --stdin in favor of --annotate-stdin

Phillip Wood [off-list ref] writes:

quoted

@@ -613,8 +622,8 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix)
  	for_each_ref(name_ref, &data);
  	name_tips();
  -	if (transform_stdin) {
-		char buffer[2048];
+	if (annotate_stdin) {
+		struct strbuf sb = STRBUF_INIT;

I think this hunk belongs in the next patch. Before posting a patch
series I find it helpful to run

    git rebase --keep-base -x'make -j4 git && cd t && prove -j4 <tests
    I think might fail> :: --root=/dev/shm'

to check that the individual patches compile and pass the relevant
tests. I've never got round to trying it but git-test[1] also lets you 
test all the commits in a series

Ahh, I saw and pointed out exactly the same mistake in an earlier
round, but failed to spot it this time around.  Thanks for spotting.