Thread (82 messages) flat view 82 messages, 7 authors, 2022-01-05

Re: [PATCH v3 02/11] i18n: refactor "%s, %s and %s are mutually exclusive"

From: Jean-Noël AVILA <hidden>
Date: 2021-12-31 17:05:57

On Thursday, 30 December 2021 23:26:42 CET Junio C Hamano wrote:
"Jean-Noël Avila via GitGitGadget"  [off-list ref] writes:
quoted
 	if (use_stdout + rev.diffopt.close_file + !!output_directory > 1)
-		die(_("--stdout, --output, and --output-directory are mutually exclusive"));
+		die(_("options '%s', '%s' and '%s' cannot be used together"), "--stdout", "--output", "--output-directory");
We probably want to preserve the Oxford comma here, and unify the
ones that didn't use Oxford comma to use it.
Oh. I wasn't even aware of this holy war (https://en.wikipedia.org/wiki/Serial_comma). It would be good to add this style specification
for writing our messages and documents.

Will make another pass.

Thanks

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help