Re: [PATCH v2 0/5] Sparse checkout: fix bug with worktree of bare repo

On Mon, Dec 27, 2021 at 3:16 PM Elijah Newren [off-list ref] wrote:

On Sun, Dec 26, 2021 at 11:34 PM Eric Sunshine [off-list ref] wrote:

quoted

Your proposal is _almost_ the same as my suggestion of eventually
making per-worktree config the default. The difference is that you're
only making it the default if `core.bare=true` or `core.worktree` is
set.

Indeed.  :-)

quoted

But do we need that distinction? If people are comfortable with
that, then are they comfortable with simply flipping the switch and
making per-worktree config the default today regardless of `core.bare`
and `core.worktree`?

This is tempting, at least if we leave core.repositoryFormatVersion as
0 (see 11664196ac ("Revert "check_repository_format_gently(): refuse
extensions for old repositories"", 2020-07-15)) when core.bare is
false and core.worktree was unset.  However, for that case:

I'll try to respond to this email when I can find a quiet block of
time to really concentrate on what you're saying and reason through it
more thoroughly; it will probably require several read-throughs.