Thread (1 message) 1 message, 1 author, 2021-12-26

Re: [PATCH v5 07/10] cat-file: fix remaining usage bugs

From: Junio C Hamano <hidden>
Date: 2021-12-26 00:31:15
Subsystem: the rest · Maintainer: Linus Torvalds

Possibly related (same subject, not in this thread)

Ævar Arnfjörð Bjarmason  [off-list ref] writes:
With the migration of --batch-all-objects to OPT_CMDMODE() in the
preceding commit one bug with combining it and other OPT_CMDMODE()
options was solved, but we were still left with e.g. --buffer silently
being discarded when not in batch mode.
...
I've read the patches again myself, as I didn't see much comments to
the recent rounds of the series on the list.  Here are a few fix-ups
to style violations that made my reading hiccup while doing so,
introduced by this step.

----- >8 --------- >8 --------- >8 --------- >8 --------- >8 -----
Subject: [PATCH] fixup! cat-file: fix remaining usage bugs

Style fix to have SP on both sides of

    shell_function () {
	... body of the function ...

Signed-off-by: Junio C Hamano <redacted>
---
 t/t1006-cat-file.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh
index 123801cfe2..aa859271d6 100755
--- a/t/t1006-cat-file.sh
+++ b/t/t1006-cat-file.sh
@@ -34,7 +34,7 @@ do
 	'
 done
 
-test_missing_usage() {
+test_missing_usage () {
 	test_expect_code 129 "$@" 2>err &&
 	grep -E "^fatal:.*required" err
 }
@@ -66,7 +66,7 @@ do
 	done
 done
 
-test_too_many_arguments() {
+test_too_many_arguments () {
 	test_expect_code 129 "$@" 2>err &&
 	grep -E "^fatal: too many arguments$" err
 }
-- 
2.34.1-568-g69e9fd72b5


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help