Thread (1 message) 1 message, 1 author, 2021-12-22

Re: [PATCH v2 0/6] usage API: Add and use die_message()

From: Junio C Hamano <hidden>
Date: 2021-12-22 19:59:32

Jonathan Tan [off-list ref] writes:
quoted
A small set of fixes to usage.[ch]'s API use that will go towards
enabling nicer things down the road. See [1] for the v1 summary

I believe this should address all the feedback Junio had on the
v1.

Aside from the substantially rewritten 6/6 and much simplified 4/6 the
end-state is almost the same, but things are better split up,
explained etc. now.

1. https://lore.kernel.org/git/cover-0.4-00000000000-20211206T165221Z-avarab@gmail.com/ (local)
I haven't looked at this round of patches yet, but for the convenience
of reviewers, it would have been great if you linked to a prior
discussion [1], including an email from me with comments that (as far as
I know) haven't been addressed [2].

[1] https://lore.kernel.org/git/patch-1.1-5a47bf2e9c9-20211021T114223Z-avarab@gmail.com/ (local)
[2] https://lore.kernel.org/git/20211027215053.2257548-1-jonathantanmy@google.com/ (local)
Hear, hear, and thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help