Thread (1 message) 1 message, 1 author, 2021-12-16

Re: [PATCH v3] stash: don't show "git stash push" usage on bad "git stash" usage

From: Junio C Hamano <hidden>
Date: 2021-12-16 22:05:48

Ævar Arnfjörð Bjarmason  [off-list ref] writes:
This still leaves e.g. "git stash push -h" emitting the
"git_stash_usage" output, instead of "git_stash_push_usage". That
should be fixed, but is a much deeper misbehavior in parse_options()
not being aware of subcommands at all. I.e. in how
PARSE_OPT_KEEP_UNKNOWN and PARSE_OPT_NO_INTERNAL_HELP combine in
commands such as "git stash".
I do not necessarily think that is misbehaviour to begin with, but
in any case, it is good to keep the initial fix focused on a small
and clear case, like the one the patch addresses.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help