Re: [PATCH 10/13] test-lib-functions: add and use a "write_hook" wrapper

On Mon, Dec 13, 2021 at 11:29 AM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:

On Mon, Dec 13 2021, Eric Sunshine wrote:

quoted

It's not clear whether the intention is to maintain the &&-chain in
this function...
... or not care about it since it's broken here before `shift`...

Thanks, those should all use &&-chaining. Will fix.

By the way, the new chainlint could be made to catch broken &&-chains
(and missing `|| return 1`) in test script functions, as well; it
doesn't have to limit its checks only to tests. The reason I haven't
done so yet is that it's not clear how much we care about &&-chains in
functions, especially since we have _so many_ functions which don't
maintain the &&-chain. In the long run, I think it might be beneficial
to extend chainlint to check shell functions too, but fixing the
&&-chains in functions probably have to be done incrementally, thus
would likely require some sort of whitelisting or blacklisting
mechanism until all functions have been fixed. Anyhow, it's food for
thought.