[PATCH 0/6] Transition git-p4.py to support Python 3 only · Joel Holdsworth <hidden> · 2021-12-09
[PATCH 1/6] git-p4: Always pass cmd arguments to subprocess as a python lists · Joel Holdsworth <hidden> · 2021-12-09
[PATCH 2/6] git-p4: Don't print shell commands as python lists · Joel Holdsworth <hidden> · 2021-12-09
[PATCH 3/6] git-p4: Removed support for Python 2 · Joel Holdsworth <hidden> · 2021-12-09
Re: [PATCH 3/6] git-p4: Removed support for Python 2 · David Aguilar <hidden> · 2021-12-10
RE: [PATCH 3/6] git-p4: Removed support for Python 2 · Joel Holdsworth <hidden> · 2021-12-10
[PATCH 4/6] git-p4: Decode byte strings before printing · Joel Holdsworth <hidden> · 2021-12-09
[PATCH 5/6] git-p4: Eliminate decode_stream and encode_stream · Joel Holdsworth <hidden> · 2021-12-09
[PATCH 6/6] git-p4: Resolve RCS keywords in binary · Joel Holdsworth <hidden> · 2021-12-09
Re: [PATCH 6/6] git-p4: Resolve RCS keywords in binary · Luke Diamand <hidden> · 2021-12-10
RE: [PATCH 6/6] git-p4: Resolve RCS keywords in binary · Joel Holdsworth <hidden> · 2021-12-10
Re: [PATCH 0/6] Transition git-p4.py to support Python 3 only · Ævar Arnfjörð Bjarmason <hidden> · 2021-12-10
RE: [PATCH 0/6] Transition git-p4.py to support Python 3 only · Joel Holdsworth <hidden> · 2021-12-10
Re: [PATCH 0/6] Transition git-p4.py to support Python 3 only · Ævar Arnfjörð Bjarmason <hidden> · 2021-12-10
Re: [PATCH 0/6] Transition git-p4.py to support Python 3 only · Luke Diamand <hidden> · 2021-12-10
RE: [PATCH 0/6] Transition git-p4.py to support Python 3 only · Joel Holdsworth <hidden> · 2021-12-10
Re: [PATCH 0/6] Transition git-p4.py to support Python 3 only · Luke Diamand <hidden> · 2021-12-11
RE: [PATCH 0/6] Transition git-p4.py to support Python 3 only · Joel Holdsworth <hidden> · 2021-12-13

RE: [PATCH 0/6] Transition git-p4.py to support Python 3 only

From: Joel Holdsworth <hidden>
Date: 2021-12-13 13:47:56

quoted

What unit tests are these? I am happy to test with them.

    cd t
    make T=t98* -j$(nproc)

Awesome! Just ran the tests. We got a clean sweep.

With one proviso:

When running the current upstream master git-p4 version, there are errors if /usr/bin/python is not present.

lib-git-p4.sh checks for the presence of python with "test_have_prereq PYTHON" - but if I only have /usr/bin/python3 installed, the prerequisite check passes, but git-p4.py itself fails because the shebang points at python not python3.

On Debian installing the package "python-is-python3" fixes the issue.

Perhaps it might help to have something like "test_have_prereq PYTHON3".

Regardless, if python3 is installed, this patch-set passes the tests just fine.

Joel

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help