Thread (16 messages) 16 messages, 9 authors, 2021-12-15

ms/customizable-ident-expansion (was: What's cooking in git.git (Dec 2021, #03; Fri, 10))

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-12-12 22:47:52

On Fri, Dec 10 2021, Junio C Hamano wrote:

[CC-ing Maksym, the topic author]
* ms/customizable-ident-expansion (2021-09-01) 1 commit
 - keyword expansion: make "$Id$" string configurable

 Instead of "$Id$", user-specified string (like $FreeBSD$) can be
 used as an in-blob placeholder for keyword expansion.

 Will discard.
 Stalled for too long.
 cf. <xmqqfsuosvrh.fsf@gitster.g>
 cf. [ref]
 source: [ref]
I'd like to see this go in, not because I'd personally find it useful,
but mainly because I didn't find anything wrong with it (per my review
id [1] linked above), and more importantly because the saga ending here
seems rather unfriendly to a first-time contributor.

Wasn't the "stalled for too long" mainly a victim of timing? I.e. that
it happened to be submitted/discussed around the end of the last release
cycle?

Maksym: Are you interested in pursuing this still?

I think per Junio's[2] an updated commit message describing some of the
use-case (and in particular how/why .gitattributes v.s. a git config
setting is needed) might be enough to help move this forward.

1. https://lore.kernel.org/git/211101.86fssf3bn3.gmgdl@evledraar.gmail.com/ (local)
2. https://lore.kernel.org/git/xmqqwnlito0b.fsf@gitster.g/ (local)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help