Thread (4 messages) flat view 4 messages, 3 authors, 2021-12-10

RE: [PATCH 4/6] git-p4: Decode byte strings before printing

From: Joel Holdsworth <hidden>
Date: 2021-12-10 10:41:52

Is the use of strings with {} placeholders and their .format() method integral
part of "decoding byte strings before printing", or it is just a
new/better/improved/subjectively-preferred/whatever style?

If the latter, such a change should be separated into its own step, or at least
needs to be mentioned and justified in the proposed log message.
As I mentioned in my other message, I would like to invest some time into tidying and modernising the script - as well as fixing bugs and improving behaviour. If I submit patches that only make subjective style improvements, are these likely to be accepted?
Lack of explanation on "why" is shared among all these patches, it seems, so I
won't repeat, but the patches need to explain why to their readers.
Fair enough. I will resubmit.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help