Thread (69 messages) 69 messages, 5 authors, 2022-01-20

Re: [PATCH v5 1/2] branch: accept multiple upstream branches for tracking

From: Glen Choo <hidden>
Date: 2021-12-09 00:08:49

Glen Choo [off-list ref] writes:
We print ref_string, which is a strbuf. This causes t/t3200-branch.sh to
segfault on my mac + clang, but inconsistently! With -O2, it doesn't
always segfault, but the wrong memory is read:

  Branch 'my3' set up to track remote branch local from 'Branch '%s' set up to track remote branch %s from '%s'.'.
I forgot to mention this earlier but in this example, the test *passes*
even though the stderr message is obviously wrong. I don't see any
coverage of the help message in t3200, which is a bit worrying to me.

After this series is done, is it worth adding test coverage of the help
message?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help