Thread (29 messages) 29 messages, 2 authors, 2021-12-07

[PATCH v4 3/8] test-ref-store: plug memory leak in cmd_delete_refs

flat view
STALE1787d

From: Han-Wen Nienhuys via GitGitGadget <hidden>
Date: 2021-12-07 13:38:29
Subsystem: the rest · Maintainer: Linus Torvalds

Revision v4 (3 revisions archived).

Revisions (3)
  1. v2
  2. v3 [diff against previous]
  3. v4 current [diff against previous]
From: Han-Wen Nienhuys <redacted>

Signed-off-by: Han-Wen Nienhuys <redacted>
---
 t/helper/test-ref-store.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/t/helper/test-ref-store.c b/t/helper/test-ref-store.c
index abb0ba101ae..8fee3cfce1a 100644
--- a/t/helper/test-ref-store.c
+++ b/t/helper/test-ref-store.c
@@ -138,11 +138,14 @@ static int cmd_delete_refs(struct ref_store *refs, const char **argv)
 	unsigned int flags = arg_flags(*argv++, "flags", transaction_flags);
 	const char *msg = *argv++;
 	struct string_list refnames = STRING_LIST_INIT_NODUP;
+	int result;
 
 	while (*argv)
 		string_list_append(&refnames, *argv++);
 
-	return refs_delete_refs(refs, msg, &refnames, flags);
+	result = refs_delete_refs(refs, msg, &refnames, flags);
+	string_list_clear(&refnames, 0);
+	return result;
 }
 
 static int cmd_rename_ref(struct ref_store *refs, const char **argv)
-- 
gitgitgadget
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help