Thread (47 messages) 47 messages, 6 authors, 2021-12-08

[PATCH v6 4/7] repo-settings: prepare_repo_settings only in git repos

flat view
STALE1768d REVIEWED: 1 (0M)

From: Lessley Dennington via GitGitGadget <hidden>
Date: 2021-12-06 16:10:47
Subsystem: the rest · Maintainer: Linus Torvalds

Revision v6 of 3 in this series; 1 review trailer.

Revisions (3)
  1. v4 [diff vs current]
  2. v5 [diff vs current]
  3. v6 current
From: Lessley Dennington <redacted>

Check whether git directory exists before adding any repo settings. If it
does not exist, BUG with the message that one cannot add settings for an
uninitialized repository. If it does exist, proceed with adding repo
settings.

Signed-off-by: Lessley Dennington <redacted>
Reviewed-by: Elijah Newren <redacted>
---
 repo-settings.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/repo-settings.c b/repo-settings.c
index b93e91a212e..00ca5571a1a 100644
--- a/repo-settings.c
+++ b/repo-settings.c
@@ -17,6 +17,9 @@ void prepare_repo_settings(struct repository *r)
 	char *strval;
 	int manyfiles;
 
+	if (!r->gitdir)
+		BUG("Cannot add settings for uninitialized repository");
+
 	if (r->settings.initialized++)
 		return;
 
-- 
gitgitgadget
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help