Re: [PATCH 00/10] Factorization of messages with similar meaning
From: Junio C Hamano <hidden>
Date: 2021-12-05 19:30:48
"Jean-Noël Avila via GitGitGadget" [off-list ref] writes:
This series is a meager attempt at rationalizing a small fraction of the internationalized messages. Sorry in advance for the dull task of reviewing these insipide patches. Doing so has some positive effects: * non-translatable constant strings are kept out of the way for translators * messages with identical meaning are built identically * the total number of messages to translate is decreased. I'm inclined to even go a step further and turn these messages into #define or const strings.
After looking at [01/10] that repeats the same string in many places, I would have to say that we do not want such C preprocessor macros. Having to hunt for an existing message that is close enough to what you want to say, when you are writing a new message, feels a bit too much. I wonder if a tool that - looks for "newly added" messages (by scanning "git diff" output) - compares them with po/git.pot for existing msgid in a fuzzy way to locate the ones that may be candidate for a change like the changes in this series can help developers, though. Thanks.