Re: [PATCH] editor: only save (and restore) the terminal if using a tty

On Tue, Nov 30, 2021 at 2:41 PM Phillip Wood [off-list ref] wrote:

On 23/11/2021 17:31, Carlo Arenas wrote:

quoted

Restricting this feature further, maybe through a configuration
property or even special casing the EDITOR is also IMHO a good idea.

I think just doing this when we run the editor may be the way to go as I
think it is only that case that can mess up the terminal.

If it only happens with certain versions of vi / vim, perhaps Git could come
with a front end program that saves the tty state, runs vim, and restores the
tty state. (Or set this up so that the program can run any editor.)  Then add
a FAQ entry if needed: "if your editor goofs up the terminal, insert this front
end program".

Chris