Re: What's cooking in git.git (Nov 2021, #07; Mon, 29)
flat view
From: Aleen 徐沛文 <hidden>
Date: 2021-12-01 01:43:06
Please don't, at least not this version. There have been newer submissions with three commits. I also still find the word 'die' confusing, since to me it suggests aborting the whole am operation, and the documentation does not dispel that concern. Even if you don't like 'ask' (for consistency with git-rebase), I think 'stop' or 'interrupt' would be much better options than 'die'. If you really want it to be 'die', I think the behavior needs to be explained in the documentation, rather than just assumed that users will understand it (because I didn't understand it until I read the code).
Dears Newren,
I don't think 'stop' and 'interrupt' words are better to explain more than 'die'
because they still indicate that it will stop or interrupt the whole am session,
rather than stop in the middle of it. It may be a good choice to just add an
additional description about the behaviour when not passing the '--empty' option
or passing '--empty=die'.
Aleen