Re: [PATCH v4 3/4] diff: enable and test the sparse index
From: Junio C Hamano <hidden>
Date: 2021-11-23 23:48:31
"Lessley Dennington via GitGitGadget" [off-list ref] writes:
quoted hunk
diff --git a/builtin/diff.c b/builtin/diff.c index dd8ce688ba7..fa4683377eb 100644 --- a/builtin/diff.c +++ b/builtin/diff.c@@ -437,6 +437,11 @@ int cmd_diff(int argc, const char **argv, const char *prefix) prefix = setup_git_directory_gently(&nongit); + if (!nongit) { + prepare_repo_settings(the_repository); + the_repository->settings.command_requires_full_index = 0; + } +
It is very pleasing to see that with all the preparations, it is jsut a very simple matter of adding four lines to enable the big feature. At this point immediately after asking setup_git_directory_gently(), we positively know if we are in a repository, so the placement of the new code makes perfect sense. Nice.