Thread (2 messages) flat view 2 messages, 2 authors, 2021-11-23
STALE1764d

[RFC PATCH] Makefile: add deprecation message for strip target

From: Bagas Sanjaya <hidden>
Date: 2021-11-23 12:29:50
Subsystem: kernel build + files below scripts/ (unless maintained elsewhere), the rest · Maintainers: Nathan Chancellor, Nicolas Schier, Linus Torvalds

Now that $INSTALL_STRIP variable can be defined since 3231f41009 (make:
add INSTALL_STRIP option variable, 2021-09-05), deprecate 'strip' target
to encourage users to move to $INSTALL_STRIP. The target will eventually
be removed in Git 2.35+1.

Only deprecation message is printed.

Signed-off-by: Bagas Sanjaya <redacted>
---
 Makefile | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/Makefile b/Makefile
index 12be39ac49..ee83860f7d 100644
--- a/Makefile
+++ b/Makefile
@@ -2159,6 +2159,8 @@ please_set_SHELL_PATH_to_a_more_modern_shell:
 shell_compatibility_test: please_set_SHELL_PATH_to_a_more_modern_shell
 
 strip: $(PROGRAMS) git$X
+	@echo "The 'strip' target is deprecated, define INSTALL_STRIP if you want to"
+	@echo "install Git with stripped binaries."
 	$(STRIP) $(STRIP_OPTS) $^
 
 ### Flags affecting all rules
base-commit: cd3e606211bb1cf8bc57f7d76bab98cc17a150bc
-- 
An old man doll... just what I always wanted! - Clara
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help