Thread (15 messages) flat view 15 messages, 6 authors, 2021-11-19

Re: [PATCH 1/3] diff histogram: intern strings

From: Jeff King <hidden>
Date: 2021-11-18 15:42:56

On Thu, Nov 18, 2021 at 04:35:48PM +0100, Johannes Schindelin wrote:
I think the really important thing to point out is that
`xdl_classify_record()` ensures that the `ha` attribute is different for
different text. AFAIR it even "linearizes" the `ha` values, i.e. they
won't be all over the place but start at 0 (or 1).

So no, I'm not worried about collisions. That would be a bug in
`xdl_classify_record()` and I think we would have caught this bug by now.
Ah, thanks for that explanation. That addresses my collision concern from
earlier in the thread completely.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help