Re: [PATCH v2] fetch-pack: parameterize message containing 'ready' keyword

On Thu, Nov 18 2021, Eric Sunshine wrote:

On Thu, Nov 18, 2021 at 5:35 AM Bagas Sanjaya [off-list ref] wrote:

quoted

The protocol keyword 'ready' isn't meant for translation. Pass it as
parameter instead of spell it in die() message (and potentially confuse
translators).

Signed-off-by: Bagas Sanjaya <redacted>
---

diff --git a/fetch-pack.c b/fetch-pack.c

@@ -1410,9 +1410,13 @@ static int process_ack(struct fetch_negotiator *negotiator,
        if (*received_ready && reader->status != PACKET_READ_DELIM)
-               die(_("expected packfile to be sent after 'ready'"));
+               /* TRANSLATORS: The parameter will be 'ready', a protocol
+                * keyword */
+               die(_("expected packfile to be sent after '%s"), "ready");

Missing closing single-quote after %s.

quoted

        if (!*received_ready && reader->status != PACKET_READ_FLUSH)
-               die(_("expected no other sections to be sent after no 'ready'"));
+               /* TRANSLATORS: The parameter will be 'ready', a protocol
+                * keyword */
+               die(_("expected no other sections to be sent after no '%s"), "ready");

Missing closing single-quote after %s.

Also s/be sent after no/be sent after/, i.e. there's a stray "no".