Re: [PATCH] Use mingw.h declarations for gmtime_r/localtime_r on msys2

On Tue, Oct 05, 2021 at 12:12:12AM -0700, Carlo Arenas wrote:

On Mon, Oct 4, 2021 at 11:57 PM Mike Hommey [off-list ref] wrote:

quoted

A possible alternative fix would be to e.g. add `#define _POSIX_C_SOURCE
200112L` to git-compat-util.h and add `ifndef __MINGW64_VERSION_MAJOR`
around the definitions of `gmtime_r` and `localtime_r` in
compat/mingw.c, since, after all, they are available there.

something like that was merged to "main"[1] a few months ago, would
that work for you?

Carlo

[1] https://github.com/git-for-windows/git/commit/9e52042d4a4ee2d91808dda71e7f2fdf74c83862

Since this reached 2.34, I gave it a try, and it turns out this didn't
fix it:
date.c:70:9: error: implicit declaration of function 'gmtime_r'; did you mean 'gmtime_s'? [-Werror=implicit-function-declaration]
date.c:76:9: error: implicit declaration of function 'localtime_r'; did you mean 'localtime_s'? [-Werror=implicit-function-declaration]

(presumably because _POSIX_C_SOURCE is not defined)