[PATCH] mergesort: avoid left shift overflow
flat view
STALE1789d
From: René Scharfe <hidden>
Date: 2021-11-15 23:22:13
Subsystem:
the rest · Maintainer:
Linus Torvalds
Use size_t to match n when building the bitmask for checking whether a rank is occupied, instead of the default signed int. Signed-off-by: René Scharfe <redacted> --- Ugh, sorry. :( mergesort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mergesort.c b/mergesort.c
index 6216835566..bd9c6ef8ee 100644
--- a/mergesort.c
+++ b/mergesort.c@@ -63,7 +63,7 @@ void *llist_mergesort(void *list, void *next = get_next_fn(list); if (next) set_next_fn(list, NULL); - for (i = 0; n & (1 << i); i++) + for (i = 0; n & ((size_t)1 << i); i++) list = llist_merge(ranks[i], list, get_next_fn, set_next_fn, compare_fn); n++; --
2.33.1