Re: [PATCH] fetch-pack: add TRANSLATORS notice for packfile ready messages

On Mon, Nov 15 2021, Bagas Sanjaya wrote:

On 14/11/21 16.50, Ævar Arnfjörð Bjarmason wrote:

quoted

If something isn't meant to be translated do this instead:
     die(_("expected no other sections to be sent after no '%s"),
"ready");
I.e. pass it as a parameter.
There can then be a "TRANSLATORS" comment that explains that it's
the
string "ready", in reference to that protocol keyword. We do it that way
in various other places, and it completely avoids the potential problem
of a should not be translated string being translated.

Something like:
/* TRANSLATORS: The 'ready' string is the protocol keyword. Leave it
   as is. */ ?

No, e.g. "TRANSLATORS: The parameter will be 'ready', a protocol
keyword" or something.

I.e. you don't need to instruct them to leave it as-is if there's no way
they can't leave it as-is, since it's being passed as a parameter.

But I have admitted that I lean to your suggestion.

Yes you could also embed it in the string, but why do that in this case?
Seems like zero benefit, and potential translator confusion.