Thread (2 messages) flat view 2 messages, 2 authors, 2021-11-14

Re: [PATCH] MyFirstContribution.txt: fix undeclared variable i in sample code

From: Junio C Hamano <hidden>
Date: 2021-11-14 06:41:20

Possibly related (same subject, not in this thread)

Saksham Mittal [off-list ref] writes:
quoted
It is declared, there is an "int i;" a few lines up.
Oh, man, I never even saw that! The patch is completely unnecessary
then. Sorry for that!
No need to say sorry; you'd want to be a bit more careful next time,
that's all.

Also, our code does not introduce a new variable in the first part
of "for (;;)" loop control, so even if the original lacked decl for
"i", the posted patch is not how we write our code for this project.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help