Thread (1 message) 1 message, 1 author, 2021-11-12

Re: [PATCH v2 1/8] grep.h: remove unused "regex_t regexp" from grep_opt

From: Junio C Hamano <hidden>
Date: 2021-11-12 16:11:24

Ævar Arnfjörð Bjarmason  [off-list ref] writes:
quoted hunk
This "regex_t" in grep_opt has not been used since
f9b9faf6f8a (builtin-grep: allow more than one patterns., 2006-05-02),
we still use a "regex_t" for compiling regexes, but that's in the
"grep_pat" struct".

Signed-off-by: Ævar Arnfjörð Bjarmason <redacted>
---
 grep.h | 1 -
 1 file changed, 1 deletion(-)
diff --git a/grep.h b/grep.h
index 3e8815c347b..95cccb670f9 100644
--- a/grep.h
+++ b/grep.h
@@ -136,7 +136,6 @@ struct grep_opt {
 
 	const char *prefix;
 	int prefix_length;
-	regex_t regexp;
 	int linenum;
 	int columnnum;
 	int invert;
I would have expected "this used to be used but no longer; only
initialization of and assignment to it remain"; I am somewhat
surprised to see there is no mention to it anywhere in the code ;-)

Good find.  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help