Thread (2 messages) flat view 2 messages, 2 authors, 2021-11-12

Re: [PATCH] simple-ipc: work around issues with Cygwin's Unix socket emulation

From: Adam Dinwoodie <hidden>
Date: 2021-11-12 08:51:15

On Wed, 10 Nov 2021 at 17:11, Junio C Hamano [off-list ref] wrote:
"Johannes Schindelin via GitGitGadget" [off-list ref]
writes:
quoted
From: Johannes Schindelin <redacted>

Cygwin emulates Unix sockets by writing files with custom contents and
then marking them as system files.

The tricky problem is that while the file is written and its `system`
bit is set, it is still identified as a file. This caused test failures
when Git is too fast looking for the Unix sockets and then complains
that there is a plain file in the way.

Let's work around this by adding a delayed retry loop, specifically for
Cygwin.

Signed-off-by: Johannes Schindelin <redacted>
---
OK, I was about to ask for an Ack from Cygwin folks but I see the
original that got Ack is more-or-less the same except for placement
of the comments (and this version of course is more polished than
the "this should work---please try it" version), so let me pretend
that this got tested-by from those who were happy with the original
in the old thread.
Late to the party – other bits of life got in the way – but I've just
confirmed this appears to resolve the issue for me too.

Adam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help