Re: [RFC PATCH] receive-pack: run post-receive before reporting status
From: Robin Jarry <hidden>
Date: 2021-11-06 21:32:49
From: Robin Jarry <hidden>
Date: 2021-11-06 21:32:49
Hi Ævar, Ævar Arnfjörð Bjarmason, Nov 06, 2021 at 06:03:
FWIW we include the date when mentioning commits. E.g. ec7dbd145bd (receive-pack: allow hooks to ignore its standard input stream, 2014-09-12).
OK, noted.
I think the discussion at [1] is current to everything you're seeing here.
Thanks I had missed this thread.
tl;dr: Even with this change you're not guaranteed to run your hook.
[snip]
But as noted in [1] there's a way forward to having our cake & eating it too. I.e. when we into that on the server-side we can try a little harder not to die, and run post-receive anyway, and in either case it would be nice if we'd run it after disconnecting from the client, so it doesn't have to wait for it.
OK, I will try to propose a v2 masking SIGPIPE when reporting status to the client to avoid dying before running post-receive. Cheers, -- Robin