Re: [PATCH v3 03/10] generate-cmdlist.sh: spawn fewer processes
From: Junio C Hamano <hidden>
Date: 2021-11-05 22:47:20
Ævar Arnfjörð Bjarmason [off-list ref] writes:
quoted hunk
diff --git a/generate-cmdlist.sh b/generate-cmdlist.sh index 5114f46680a..27367915611 100755 --- a/generate-cmdlist.sh +++ b/generate-cmdlist.sh@@ -11,15 +11,14 @@ command_list () { get_categories () { tr ' ' '\012' | - grep -v '^$' | - sort | - uniq + LC_ALL=C sort -u } category_list () { command_list "$1" | cut -c 40- | - get_categories + get_categories | + grep -v '^$' }
It is funny that this changes "grep then sort" into "sort then grep", which will be "corrected" in two steps down. The series seems a bit over-engineered and broken down too much, at least to me, but let's not waste any more time on it by an extra reroll.