Re: surprising value of LARGE_PACKET_MAX

On Thu, Nov 4, 2021 at 4:08 PM Joey Hess [off-list ref] wrote:

The docs don't say what the maximum size is, so I assumed I could make
it as large as the length header allows, which I think is a natural
conclusion to draw from the documentation. But looking in git's source,
fff0 is the maximum:

#define LARGE_PACKET_MAX 65520
#define LARGE_PACKET_DATA_MAX (LARGE_PACKET_MAX - 4)

[...]

Perhaps the best thing to do would be to document it in
Documentation/technical/protocol-common.txt

Could it be that you consulted an older version of this file? The
current [1] version of the doc says:

"The maximum length of a pkt-line's data component is 65516 bytes.
Implementations MUST NOT send pkt-line whose length exceeds 65520
(65516 bytes of payload + 4 bytes of length data)."

[1]: https://github.com/git/git/blob/master/Documentation/technical/protocol-common.txt