Thread (1 message) 1 message, 1 author, 2021-11-04

Re: [PATCH v4 8/8] clean/smudge: allow clean filters to process extremely large files

From: Junio C Hamano <hidden>
Date: 2021-11-04 17:26:59

"Matt Cooper via GitGitGadget" [off-list ref] writes:
 struct filter_params {
 	const char *src;
-	unsigned long size;
+	size_t size;
 	int fd;
 	const char *cmd;
 	const char *path;
OK, this member is used in only two places in the file.  One is used
as a parameter to write_in_full() that is prepared to take size_t.
The other is to assign to this member from a size_t parameter the
apply_single_file_filter() function got from the caller, and the
callchain leading down to the function are size_t aware.

So, this may only make "a small dent" as described in the proposed
log message, but it does move it in the right direction.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help