Thread (5 messages) flat view 5 messages, 3 authors, 2021-11-03

Re: [PATCH v4 04/13] dir: fix pattern matching on dirs

From: Junio C Hamano <hidden>
Date: 2021-11-02 00:34:09

Possibly related (same subject, not in this thread)

Glen Choo [off-list ref] writes:
This patch changes the behavior of .gitignore such that directories are
now matched by prefix instead of matching exactly.

The failure that we observed is something like the following:

In "a/.gitignore", we have the pattern "git/". We should expect that
"a/git/foo" to be ignored because "git/" should be matched exactly.
However, "a/git-foo/bar" is also ignored because "git-foo" matches the
prefix.

I'll prepare a test case for this as soon as I figure out how to write
it..
FWIW, reverting this commit (and nothing else) from 'master' does not
seem to break any test.  That does not necessarily mean much (it may
be indicating a gap in the test coverage).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help