RE: [PATCH] wrapper: remove xunsetenv()

On October 29, 2021 5:43 PM, Carlo Arenas wrote:

On Fri, Oct 29, 2021 at 2:37 PM [off-list ref] wrote:

quoted

I will be submitting a separate patch to turn off NO_SETENV and

NO_UNSETENV for the NonStop x86 platform, where the calls have been
supported since October 2020. The ia64 platform will have to continue to use
the compat layer.

The right place to add that logic is most likely in config.mak.uname; see all the
other conditions that match based on version as a guideline.

Already there. I just want to make sure everything is fine on the older box. This will be it, but I'm looking at whether I can get rid of any other switches at the same time:

diff --git a/config.mak.uname b/config.mak.uname
index 3236a491..fdcc4690 100644
--- a/config.mak.uname
+++ b/config.mak.uname

@@ -569,8 +569,11 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
        NO_STRCASESTR = YesPlease
        NO_MEMMEM = YesPlease
        NO_STRLCPY = YesPlease
-       NO_SETENV = YesPlease
-       NO_UNSETENV = YesPlease
+       ifeq ($(uname_R),J06)
+               # setenv and unsetenv are not supported on J-series
+               NO_SETENV = YesPlease
+               NO_UNSETENV = YesPlease
+       endif
        NO_MKDTEMP = YesPlease
        # Currently libiconv-1.9.1.
        OLD_ICONV = UnfortunatelyYes