Re: [PATCH v2] completion: fix incorrect bash/zsh string equality check
From: Junio C Hamano <hidden>
Date: 2021-10-28 16:36:39
"Robert Estelle via GitGitGadget" [off-list ref] writes:
quoted hunk
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 4bdd27ddc87..8ca9b15f21d 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash@@ -515,7 +515,7 @@ __gitcomp_file () # argument, and using the options specified in the second argument. __git_ls_files_helper () { - if [ "$2" == "--committable" ]; then + if [ "$2" = "--committable" ]; then __git -C "$1" -c core.quotePath=false diff-index \ --name-only --relative HEAD -- "${3//\\/\\\\}*" elsebase-commit: 225bc32a989d7a22fa6addafd4ce7dcd04675dbf
Thanks. We can trace this back to April 2013, if not earlier. It is sort of surprising that nobody else has noticed it since then X-<. Will queue. Thanks, again.