Re: [PATCH 3/3] bundle-uri client: add "bundle-uri" parsing + tests
From: Derrick Stolee <hidden>
Date: 2021-10-26 14:05:38
From: Derrick Stolee <hidden>
Date: 2021-10-26 14:05:38
On 10/25/2021 5:25 PM, Ævar Arnfjörð Bjarmason wrote:
Add a "test-tool bundle-uri parse" which parses the format defined in the newly specified "bundle-uri" command. As note in the "bundle-uri" section in protocol-v2.txt we haven't specified any key-values yet, just URI lines, but we should parse their format for conformity with the spec. We need to make sure our future client doesn't die if this optional data is ever provided by the server, and that we've covered all the edge cases with these key-values in our specification. Let's add and test a bundle_uri_parse_line() to do that.
While this implementation is interesting, and the tests available are useful for validating the protocol, I would like to see how this integrates into a full 'git clone' operation to be sure that the API is correct. How much more work is it to implement the full end-to-end scenario? Thanks, -Stolee