Re: [PATCH 10/11] pack-bitmap-write.c: don't return without stop_progress()
From: Junio C Hamano <hidden>
Date: 2021-10-23 20:28:21
Junio C Hamano [off-list ref] writes:
quoted
Looks good :) Just a note that this is in "ab/only-single-progress-at-once" already in case you didn't spot it. That series is marked for "next?" (with a question mark) by Junio in the latest what's cooking, so *hint* *hint* for any last minute review :)I wonder if it would help contributors if we give them a simple rule to follow before sending their patches out: - You develop on an appropriate base (either on maint, or master, or a merge of selected topics in flight you absolutely have to depend on) as usual. - You test merge the result to 'seen' and to 'next'. If you do not get heavy conflicts and the tests pass, you are OK. - Otherwise, you study what is conflicting, and should review it before you submit your topic.
Addendum to this third step.
... Also, if you chose to depend on other topics when you
decided on the base in the first step, giving them your review
would be a good way to show others that _you_ understand the
code that you are building on top of, which in turn may give
others confidence in your topic.
Thanks.