Thread (1 message) 1 message, 1 author, 2021-10-21

Re: [PATCH 2/6] grep: use object_array_clear() in cmd_grep()

From: Junio C Hamano <hidden>
Date: 2021-10-21 23:58:45

Ævar Arnfjörð Bjarmason  [off-list ref] writes:
quoted hunk
Free the "struct object_array" before exiting. This makes grep tests
(e.g.  "t7815-grep-binary.sh") a bit happer under SANITIZE=leak.

Signed-off-by: Ævar Arnfjörð Bjarmason <redacted>
---
 builtin/grep.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/builtin/grep.c b/builtin/grep.c
index fd184c182a3..555b2ab6008 100644
--- a/builtin/grep.c
+++ b/builtin/grep.c
@@ -1196,6 +1196,7 @@ int cmd_grep(int argc, const char **argv, const char *prefix)
 		run_pager(&opt, prefix);
 	clear_pathspec(&pathspec);
 	free_grep_patterns(&opt);
+	object_array_clear(&list);
 	free_repos();
 	return !hit;
 }
Not a new issue introduced by this patch, but after run_pager(), it
seems that opt.output_priv aka path_list is never cleared.  Should
this step do that, too, as the series never revisits this file?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help