Re: [PATCH v4] sparse index: fix use-after-free bug in cache_tree_verify()

On 10/17/2021 1:38 AM, Junio C Hamano wrote:

"Phillip Wood via GitGitGadget" [off-list ref] writes:

quoted

    [RFC] sparse index: fix use-after-free bug in cache_tree_verify()
    
    Changes since V3
    
     * removed "-q" from the test [1]. This is the same as V2 with a typo
       fixed in the commit message
    
    [1] https://lore.kernel.org/git/
    e281c2e2-2044-1a11-e2bc-5ab3ee92c300@gmail.com/

Thanks.  Unfortunately I've already merged the previosu version on
the 11th, so I took the liberty of turning this round into an
incremental.  How does this look?

----- >8 --------- >8 --------- >8 --------- >8 -----
From: Phillip Wood <redacted>
Date: Sat, 16 Oct 2021 09:07:09 +0000
Subject: [PATCH] t1092: run "rebase --apply" without "-q" in the test

We run a few Git subcommands and make sure they produce identical
results with and without sparse-index.  To this set of subcommands,
an earlier commit added "rebase --apply", but did so with the "-q"
option, in order to work around a breakge caused by a version used

s/breakge/breakage/

at Microsoft with some unreleased changes.

Because we would want to make sure the commands produce indentical

s/indentical/identical/

results, including reports given to the output that lists which
commits were picked, use of "-q" loses too much interesting
information.  Let's drop "-q" from the command invocation and
revisit the issue when the problematic changes are upstreamed.

I think this summarizes the situation quite well. Thanks.

-Stolee