Thread (1 message) 1 message, 1 author, 2021-10-15

Re: [PATCH v4 0/3] Use default values from settings instead of config

From: Junio C Hamano <hidden>
Date: 2021-10-15 15:57:43

Junio C Hamano [off-list ref] writes:
Derrick Stolee [off-list ref] writes:
quoted
I generally consider any interaction with the commit-graph while
replace refs are enabled to be the bug. We don't read the commit-graph
when replace refs are on, so why are we verifying it?

But, I understand the desire to check the on-disk content even though
it is not being used, so disabling replace refs to do the verify should
be sufficient.
That's quite a sensible argument.  Sounds like we have a way to
solve this that everybody agrees with.
Would it be sensible to silently ignore, though?  Would a warning,
when we see replacement is in use and an explicit request by an end
user is made to make use of or update the commit-graph, be too loud?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help