Re: [BUG] credential wildcard does not match hostnames containing an underscore

On Tue, Oct 12, 2021 at 08:00:55PM +0200, Alex Waite wrote:

From a user perspective, a URL containing an underscore in the
hostname works for everything else (including all other git
operations), but not with pattern matching. It took me a couple hours
to figure out /why/, as GIT_TRACE does not provide debugging for how
git config rules do (or don't) match patterns.

One thing I noticed here: url_normalize() does complain about parsing
this URL, but we don't propagate its error message to stderr. Perhaps we
should do so with warning(), but I'm a bit afraid that we may be relying
on this code to silently ignore invalid urls (i.e., showing the error
would cause some other innocuous cases to start issuing noisy and
useless warnings).

-Peff