Re: [PATCH] gitk: avoid hardcoded 40 character length for oid

On Mon, Oct 11, 2021 at 1:04 PM Eric Sunshine [off-list ref] wrote:

On Mon, Oct 11, 2021 at 3:56 PM Carlo Marcelo Arenas Belón

quoted

diff --git a/gitk b/gitk

@@ -12338,6 +12347,18 @@ catch {
+if {![catch {exec git config --get extensions.objectformat} oid_type]
+    && $oid_type eq "sha256" } {
+    set oid_size 64
+} else {
+    set oid_type "sha1"
+    set oid_size 40
+}

Should this be using:

    git rev-parse --show-object-format

rather than `git-config`?

definitely a better fit, will be included in the next version.

Carlo