Re: Giving priority to the reftable topic (was Re: What's cooking in git.git (Aug 2021, #06; Mon, 16))

On Sat, Aug 21, 2021 at 12:08 AM Ramsay Jones
[off-list ref] wrote:

Just a gentle reminder that this topic tickles my 'static-check.pl'
script, like so:

  $ diff nsc ssc
  ...
  88a91,98
  > reftable/generic.o  - reftable_table_seek_log
  > reftable/merged.o   - reftable_merged_table_hash_id
  > reftable/merged.o   - reftable_merged_table_min_update_index
  > reftable/merged.o   - reftable_merged_table_seek_log_at
  > reftable/publicbasics.o     - reftable_set_alloc
  > reftable/reader.o   - reader_seek
  > reftable/reader.o   - reftable_reader_seek_log_at
  > reftable/stack.o    - reftable_stack_auto_compact
  ...
  $

Which is to say, all of the above symbols are defined (and called) in
the '.c' file corresponding to the given object file, but not called
anywhere outside that file. I have not even looked at those functions,
but (with the possible exception of reftable_set_alloc()) they don't
strike me as 'public API functions'. So, maybe they should be marked
as 'static'?

They're all public except reader_seek().
I added some more coverage, in v4 of the library topic.

--
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado