Thread (1 message) 1 message, 1 author, 2021-09-30

Re: [PATCH v6 1/5] difftool: create a tmpdir path without repeated slashes

From: Junio C Hamano <hidden>
Date: 2021-09-30 21:45:12

David Aguilar [off-list ref] writes:
The paths generated by difftool are passed to user-facing diff tools.
Using paths with repeated slashes in them is a cosmetic blemish that
is exposed to users and can be avoided.

Use a strbuf to create the buffer used for the dir-diff tmpdir.
Strip trailing slashes from the value read from TMPDIR to avoid
repeated slashes in the generated paths.

Adjust the error handling to avoid leaking strbufs.

Signed-off-by: David Aguilar <redacted>
---
This patch is a resend based off of "next" so that this series can be
tracked together.

This patch is unchanged since the v5 was submitted, but there are
new related patches that proceed it.
OK.  I confirmed that this is unchanged from the first step of v5.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help