Re: [PATCH 2/7] sparse-index: update command for expand/collapse test
From: Taylor Blau <hidden>
Date: 2021-09-30 19:17:51
On Thu, Sep 30, 2021 at 02:50:56PM +0000, Victoria Dye via GitGitGadget wrote:
quoted hunk ↗ jump to hunk
From: Victoria Dye <redacted> In anticipation of multiple commands being fully integrated with sparse index, update the test for index expand and collapse for non-sparse index integrated commands to use `mv`. Signed-off-by: Victoria Dye <redacted> --- t/t1092-sparse-checkout-compatibility.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/t/t1092-sparse-checkout-compatibility.sh b/t/t1092-sparse-checkout-compatibility.sh index c5977152661..aed8683e629 100755 --- a/t/t1092-sparse-checkout-compatibility.sh +++ b/t/t1092-sparse-checkout-compatibility.sh@@ -642,7 +642,7 @@ test_expect_success 'sparse-index is expanded and converted back' ' init_repos && GIT_TRACE2_EVENT="$(pwd)/trace2.txt" GIT_TRACE2_EVENT_NESTING=10 \ - git -C sparse-index -c core.fsmonitor="" reset --hard && + git -C sparse-index -c core.fsmonitor="" mv a b &&
Double-checking my understanding as somebody who is not so familiar with t1092: this test is to ensure that commands which don't yet understand the sparse index can temporarily expand it in order to do their work? If so, makes sense to me. And renaming 'a' to 'b' is arbitrary and fine to do since we end up recreating the sparse-index repository each time via init_repos. Looks good to me. Thanks, Taylor