Re: [PATCH 02/10] parse-options.[ch]: consistently use "enum parse_opt_flags"
From: Junio C Hamano <hidden>
Date: 2021-09-29 16:02:57
Ævar Arnfjörð Bjarmason [off-list ref] writes:
Use the "enum parse_opt_flags" instead of an "int flags" as arguments ...
quoted hunk
@@ -861,7 +864,7 @@ int parse_options(int argc, const char **argv, const char *prefix, case PARSE_OPT_NON_OPTION: case PARSE_OPT_DONE: break; - default: /* PARSE_OPT_UNKNOWN */ + case PARSE_OPT_UNKNOWN: if (ctx.argv[0][1] == '-') { error(_("unknown option `%s'"), ctx.argv[0] + 2); } else if (isascii(*ctx.opt)) {
This part does not belong to this step or 03/10 (parse_opt_result). It belongs to 04/10 (drop default from switching on enum).