Re: [PATCH v3 2/2] lazyload.h: use an even more generic function pointer than FARPROC

On Mon, Sep 27, 2021 at 9:35 AM Junio C Hamano [off-list ref] wrote:

Carlo Marcelo Arenas Belón  [off-list ref] writes:

quoted

Because of the way the function declaration was done in the previous
patch the order of variables that use it had to be adjusted so that
it is the last variable declared, as well.

Is it clear to everybody what this paragraph is referring to?  It is
not, at least to me.

It is not, and it is no longer needed after the fixup was applied to
the previous
patch.  Do you want me to send another series removing it or can be done
while applying?

It was slightly better explained in the fixup[1] commit message.

Because of the double ';', When the macro was used to declare a
function variable
and it was not the last variable declared, then it will trigger
-Wdeclaration-after-statement.

Carlo

[1] https://lore.kernel.org/git/3f963bba-3197-8c52-9828-6d78ef1d25b1@kdbg.org/ (local)