Thread (2 messages) flat view 2 messages, 2 authors, 2021-09-24

Re: [PATCH] send-email: clarify dual-mode behavior

From: Carlo Arenas <hidden>
Date: 2021-09-24 18:56:10

On Fri, Sep 24, 2021 at 10:53 AM Junio C Hamano [off-list ref] wrote:
quoted
+'git send-email' [<options>] <file|directory>...
+'git send-email' [<options>] <revision range>
... this is not improving Thiago's [3/3], I suspect.
I think it does; after all, the original (which I know you proposed)
did confuse Bagas who thought it might be missing the tagging of being
optional.

The other reasons why this might be better are :
* because of the points and examples you provided, a vague [<options>]
is better than something that might imply all options taken from
format-patch make sense here, which IMHO might be difficult to
understand as logical to you as an experienced user.
* avoids "promoting" this mode, which is known to be problematic as it
could lead to patch bombs without the proper review.  it might even be
worth adding mentions to --compose or --annotate to avoid that.

Carlo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help