Thread (2 messages) flat view 2 messages, 2 authors, 2021-09-24

Re: [PATCH v5 3/3] send-email docs: add format-patch options

From: Junio C Hamano <hidden>
Date: 2021-09-24 15:33:10

Carlo Arenas [off-list ref] writes:
On Thu, Sep 23, 2021 at 9:36 PM Bagas Sanjaya [off-list ref] wrote:
quoted
On 24/09/21 09.46, Thiago Perrotta wrote:
quoted
  SYNOPSIS
  --------
  [verse]
-'git send-email' [<options>] <file|directory|rev-list options>...
+'git send-email' [<options>] <file|directory>...
+'git send-email' [<options>] <format-patch options>
  'git send-email' --dump-aliases
Is <format-patch options> optional? If so, we can say [<format-patch
options>].
no; as Junio explained [1] this omission is intentional while the
rev-list options that
got cut to make space are not and are more relevant.

IMHO leaving [<options>] to imply ALL options (that also include diff
options, for example) is better
Could you claify this idea a bit more?  Do you mean that the second form
can just be:

	git send-email <format-patch options>

That will exclude the send-email specific ones (like
"--in-reply-to=<msg>"), so it may not be a great idea.

Or do you mean

	git send-email <options>

and have the <options> placeholder to stand for both send-email
options and options meant for format-patch?

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help