Re: [PATCH] connect: also update offset for features without values
flat view
From: Junio C Hamano <hidden>
Date: 2021-09-23 21:53:01
Possibly related (same subject, not in this thread)
- 2021-09-26 · Re: [PATCH] connect: also update offset for features without values · Andrzej Hunt <hidden>
- 2021-09-23 · Re: [PATCH] connect: also update offset for features without values · Jeff King <hidden>
- 2021-09-23 · Re: [PATCH] connect: also update offset for features without values · Junio C Hamano <hidden>
- 2021-09-19 · Re: [PATCH] connect: also update offset for features without values · Junio C Hamano <hidden>
- 2021-09-19 · Re: [PATCH] connect: also update offset for features without values · Eric Sunshine <hidden>
Jeff King [off-list ref] writes:
I think the problem is that our fake upload-pack exits immediately, so ls-remote gets SIGPIPE. In a v0 conversation, ls-remote expects to say "0000" to indicate that it's not interested in fetching anything (in v2, it doesn't bother, since fetching would be a separate request that it just declines to make).
Ah, Makes sense---the usual SIGPIPE problem ;-)
quoted hunk
This seems to fix it:diff --git a/t/t5704-protocol-violations.sh b/t/t5704-protocol-violations.sh index 34538cebf0..0983c2b507 100755 --- a/t/t5704-protocol-violations.sh +++ b/t/t5704-protocol-violations.sh@@ -40,7 +40,7 @@ test_expect_success 'bogus symref in v0 capabilities' ' test-tool pkt-line pack-raw-stdin && printf "0000" } >input && - git ls-remote --upload-pack="cat input ;:" . >actual && + git ls-remote --upload-pack="cat input; read junk;:" . >actual && printf "%s\tHEAD\n" "$oid" >expect && test_cmp expect actual '
Yup. In the original thread there was some further back-and-forth about further improving the test, if I recall correctly; has the issue been settled there, or is everybody happy with the above version? Thanks.